Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go projects to v1.19 #1237

Closed
7 tasks done
michael-valdron opened this issue Aug 31, 2023 · 10 comments
Closed
7 tasks done

Update go projects to v1.19 #1237

michael-valdron opened this issue Aug 31, 2023 · 10 comments
Assignees
Labels
area/alizer Enhancement or issue related to the alizer repo area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure kind/epic A high level requirement that can/should be split into smaller issues kind/user-story User story for new enhancement

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Aug 31, 2023

/kind user-story
/kind epic

Which area this user story is related to?

/area api
/area library
/area registry
/area alizer

User Story

As a developer of devfile, I want to provide effective patching support the user base of devfile services, so that users continue to devfile services knowing that they have the assurance that these services are receiving the security and bugfix patches when they are needed.

Part of meeting this goal is providing the patches shipped from dependencies of devfile services. With the version of Go used by most of devfile services 1.18 being EOL for some time it is becoming more difficult to provide patches from all the dependencies.

Acceptance Criteria

@openshift-ci openshift-ci bot added kind/user-story User story for new enhancement kind/epic A high level requirement that can/should be split into smaller issues area/ci area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure area/releng Release engineering labels Aug 31, 2023
@michael-valdron
Copy link
Member Author

We need to include patching dependencies as one of the tasks to do for each of the acceptance criteria items, to address issues such as #1180.

@michael-valdron
Copy link
Member Author

Before starting any child item, we need to ensure consumers of those modules are compatible with Go 1.19 (i.e. using >= 1.19).

@michael-valdron
Copy link
Member Author

Before starting any child item, we need to ensure consumers of those modules are compatible with Go 1.19 (i.e. using >= 1.19).

Some modules may not need this prerequisite, the registry index server for example would not however the devfile library and registry library would need to be compatible with consumer tools and services.

@thepetk
Copy link
Contributor

thepetk commented Sep 1, 2023

I've added some commits to update the integration-tests repo to go 1.19 here: devfile/integration-tests#99

@thepetk
Copy link
Contributor

thepetk commented Nov 10, 2023

I'm putting this item for the next refinement call. I think it might be good to refine it and prioritize it at some point. Could also be an EPIC with sub tasks per repo.

@thepetk
Copy link
Contributor

thepetk commented Nov 22, 2023

I've upgraded API to use 1.19 here: #1345
cc @michael-valdron

@jasperchui jasperchui moved this from Backlog to Refinement in Devfile Project Nov 28, 2023
@michael-valdron michael-valdron moved this from Refinement to To Do 📝 in Devfile Project Dec 1, 2023
Copy link

github-actions bot commented Mar 5, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Mar 5, 2024
@michael-valdron michael-valdron removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Mar 5, 2024
@michael-valdron
Copy link
Member Author

Still needs to be done across some of our repositories.

@thepetk
Copy link
Contributor

thepetk commented Mar 5, 2024

Still needs to be done across some of our repositories.

+1

@michael-valdron michael-valdron removed area/releng Release engineering area/ci labels Mar 6, 2024
@michael-valdron michael-valdron moved this from To Do 📝 to In Progress 🚧 in Devfile Project Mar 7, 2024
@michael-valdron michael-valdron self-assigned this Mar 7, 2024
@michael-valdron michael-valdron added the area/alizer Enhancement or issue related to the alizer repo label Mar 7, 2024
@michael-valdron
Copy link
Member Author

All maintained Go modules have been updated to Go version 1.19.

@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in Devfile Project Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alizer Enhancement or issue related to the alizer repo area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure kind/epic A high level requirement that can/should be split into smaller issues kind/user-story User story for new enhancement
Projects
Status: Done ✅
Development

No branches or pull requests

3 participants