Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'pre_get_posts' not working on search page for post types #31

Open
villesiltala opened this issue Aug 19, 2019 · 0 comments
Open

'pre_get_posts' not working on search page for post types #31

villesiltala opened this issue Aug 19, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@villesiltala
Copy link

There is a custom functionality in Geniem\RediPress\Search::posts_pre_query() that modifies post types before the search is executed. This functionality removes all modifications made in the pre_get_posts hook for the post_type query variable.

If RediPress would hook itself also on the pre_get_posts hook when modifying the post type query, plugins and other dependencies relying on that hook would not break when executing a search with RediPress.

@Nomafin Nomafin added the bug Something isn't working label Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants