Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to Humanizer #79

Open
mr-grant opened this issue Feb 19, 2025 · 0 comments
Open

Remove dependency to Humanizer #79

mr-grant opened this issue Feb 19, 2025 · 0 comments

Comments

@mr-grant
Copy link

mr-grant commented Feb 19, 2025

Hi!

In the file TrxCommand.cs there is a dependency to Humanizer, the following rows:

Image

This causes some unexpected exceptions if TRX is run on host where culture is different to EN-GB.
The exception looks like: The resource object with key 'TimeSpanHumanize_MultipleSeconds' was not found (Parameter 'resourceKey').
Probably Humanizer doesn't have all the required transaltions for a culture.
Similar issue (for milliseconds) already exist in Humanizer: Humanizr/Humanizer#1503

So, maybe it will be better to remove the dependency and just display timespan as is or another option might be to pass EN-GB culture to Humanize method, anyway the other parts of the message in English.

Thanks!

Back this issue
Back this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant