Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge commit no longer has a message #23

Open
grimsa opened this issue Nov 2, 2021 · 2 comments
Open

Merge commit no longer has a message #23

grimsa opened this issue Nov 2, 2021 · 2 comments

Comments

@grimsa
Copy link

grimsa commented Nov 2, 2021

I ran into an issue that seems to be a combination of two factors:

  1. In my GitHub Action I have to depend on a master version, because depending on a stable version is not possible (1.4.0 not found #16)
  2. master branch had a breaking change introduced with this new feature: Add an input to customize the merge message #18

Step config in my case:

      - name: Merge develop -> staging
        uses: devmasx/merge-branch@master
        with:
          type: now
          from_branch: develop
          target_branch: staging
          github_token: ${{ secrets.LYRA_REPO_ACCESS_TOKEN }}

Previously (e.g. on 2021-10-27) this resulted in a commit with a message Merge develop into staging.
Today (2021-11-02) this resulted in an empty commit message.
There was no change in configuration.

So I think these are really two issues:

  1. There is no stable release to depend on (1.4.0 not found #16)
  2. The newly added optional commit message is not really optional
@dominicarrojado
Copy link

I'm having the same issue too

@dominicarrojado
Copy link

I guess "optional" here is correct, just that there's no default one, you could add your own commit message like this instead:

      - name: Merge develop -> main
        uses: devmasx/merge-branch@master
        with:
          type: now
          message: 'merge develop into main'
          target_branch: main
          github_token: ${{ github.token }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants