Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclic dependency rule incorrect #55

Open
hohwille opened this issue Apr 25, 2023 · 0 comments
Open

cyclic dependency rule incorrect #55

hohwille opened this issue Apr 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@hohwille
Copy link
Contributor

Error:  Failures: 
Error:    Architecture Violation [Priority: HIGH] - Rule 'slices matching '..(*).(common|dataaccess|service|batch|logic|client)..' should be free of cycles, because cyclic dependencies should be prevented.' was violated (1 times):
Cycle detected: violation slice -> 
                violation slice
  1. Dependencies of violation slice
    - Class <com.devonfw.sample.archunit.violation.common.ViolationRepository> has generic interface <org.springframework.data.jpa.repository.JpaRepository<com.devonfw.sample.archunit.violation.dataaccess.ViolationEntity, java.lang.Long>> with type argument depending on <com.devonfw.sample.archunit.violation.dataaccess.ViolationEntity> in (ViolationRepository.java:0)
    - Class <com.devonfw.sample.archunit.violation.common.WrongNameRepository> has generic interface <org.springframework.data.jpa.repository.JpaRepository<com.devonfw.sample.archunit.violation.dataaccess.ViolationEntity, java.lang.Long>> with type argument depending on <com.devonfw.sample.archunit.violation.dataaccess.ViolationEntity> in (WrongNameRepository.java:0)

A component A may always depend on itself (A -> A). Therefore the cyclic dependency check is incorrect and has to be fixed.

@hohwille hohwille added the bug Something isn't working label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant