#737: Added cd command to shell commandlet #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the command cd to the shell commandlet that allows the user to switch the directory inside the ide shell
Pull Request Test Coverage Report for Build 12085518140Details
💛 - Coveralls |
jan-vcapgemini
requested changes
Nov 18, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
…dlet.java Co-authored-by: jan-vcapgemini <[email protected]>
…dlet.java Co-authored-by: jan-vcapgemini <[email protected]>
added current working directory path to prompt name improved existing directory check adjusted exit codes
removed whitespace from ide prompt
jan-vcapgemini
approved these changes
Nov 19, 2024
hohwille
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
@leonrohne27 thanks for your PR. This is nice work and you digged to find the right code locations to implement the story. 👍
I left 2 simple review comments. If you have the time left to address them this would be lovely and we can then merge. Thanks!
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
Cd without arguments now brings the user to the home path, changed the prompt String
hohwille
reviewed
Nov 29, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
…dlet.java Co-authored-by: Jörg Hohwiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #737
Implements: