Feat/unicode grapheme support #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
feat/unicode-grapheme-support
branch
from
809fb20
to
8f5f40b
Compare
arlyon
force-pushed
the
feat/unicode-grapheme-support
branch
from
8f5f40b
to
2c31fed
Compare
arlyon
added a commit
to vercel/turborepo
that referenced
this pull request
Apr 18, 2023
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
|
Closing this since it has stalled |
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #5. The PR is split into two commits. The first is kinda a precursor. I had a whole load of tests breaking to begin with which were tough to debug so now rather than a handful of tests with assertions, we now use
test_casewhich exposes pass/fail for all 1200. The second PR is the 'meat'. It overrides 3 functions based on a feature flag.To preserve performance, the non-unicode version still uses u8 rather than slices, though I feel like the perf overhead wouldn't be too large...
Note that rust requires tests to have a unique name so I have had to manually disambiguate any clashes (over 300 🥴). Some may be pretty crappy. In the process I have also removed identical tests.