Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Values assigned to cfp_link should be respected by event_link #601

Open
kmugrage opened this issue Oct 9, 2017 · 2 comments
Open

Values assigned to cfp_link should be respected by event_link #601

kmugrage opened this issue Oct 9, 2017 · 2 comments

Comments

@kmugrage
Copy link
Contributor

kmugrage commented Oct 9, 2017

Expected behavior

When adding an outside URL to cfp_link in the event's yml file I expect event_link page="propose" to use it.

Actual behavior

event_link uses internal propose page

@mattstratton
Copy link
Member

The tricky thing about this is that event_link is a shortcode whose purpose is to link to internal pages.

I propose instead adding a new shortcode for cfp_link which will link to the appropriate value for the proposal page for the event, depending on if there is an offsite cpf_link, etc. We could also add a registration_link shortcode.

I think that might be less confusing. Use case example - for Chicago, we have an offsite proposal link for the menu to use, but we still have a "propose" page, and I might want to link to it. event_link is specific for generating links internally, you know?

Thoughts?

@bridgetkromhout
Copy link
Contributor

I agree with @mattstratton that a fair number of events use the local "propose" page to explain things and then point people to their offsite CFP link. Offsite CFP links can vary so much that it doesn't make sense to assume the link will suffice for all desired explanations.

@kmugrage, what do you think of @mattstratton's proposal of adding a shortcode?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants