From 514e395b0fdfa326782ac8b509bc39508feca856 Mon Sep 17 00:00:00 2001 From: Matt Welke Date: Fri, 12 Apr 2024 15:23:41 -0400 Subject: [PATCH] fix: better error message for invalid Helm Chart path during init Signed-off-by: Matt Welke --- pkg/devspace/configure/deployment.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/pkg/devspace/configure/deployment.go b/pkg/devspace/configure/deployment.go index bd65539559..58c49570cd 100644 --- a/pkg/devspace/configure/deployment.go +++ b/pkg/devspace/configure/deployment.go @@ -141,8 +141,18 @@ func (m *manager) AddHelmDeployment(deploymentName string) error { localChartPathRel = localChartPath } - stat, err := os.Stat(path.Join(localChartPathRel, "Chart.yaml")) - if err != nil || stat.IsDir() { + pathStat, err := os.Stat(localChartPath) + if err != nil { + return err + } + + if !pathStat.IsDir() { + m.log.WriteString(logrus.InfoLevel, "\n") + m.log.Errorf("Local path `%s` is not a Helm chart (path is not a directory)", localChartPathRel) + continue + } + + if _, err := os.Stat(path.Join(localChartPathRel, "Chart.yaml")); errors.Is(err, os.ErrNotExist) { m.log.WriteString(logrus.InfoLevel, "\n") m.log.Errorf("Local path `%s` is not a Helm chart (Chart.yaml missing)", localChartPathRel) continue