Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the react components based on new updated on React version 17.x #29

Open
SaharMehrpour opened this issue Nov 19, 2019 · 1 comment
Open

update the react components based on new updated on React version 17.x #29

SaharMehrpour opened this issue Nov 19, 2019 · 1 comment
Labels
low priority

Comments

@SaharMehrpour
Copy link
Member

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move code with side effects to componentDidMount, and set initial state in the constructor.
  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: RuleTable, RulePanel, TabContent, Uncontrolled(Navbar and Tabs)
@SaharMehrpour
Copy link
Member Author

partially fixed in commit c12c41f

SaharMehrpour pushed a commit that referenced this issue Jan 15, 2020
updated componentWillReceiveProps to UNSAFE_componentWillReceiveProps…
34e7872 
… to fix warnings, issue #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SaharMehrpour