chore: revert "feat: allow option set agent replica time" #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a973a4d.
dfx-json
changed the title
size-limit report 📦
|
ericswanson-dfinity
approved these changes
Sep 28, 2024
peterpeterparker
added a commit
to dfinity/ic-js
that referenced
this pull request
Sep 30, 2024
# Motivation Agent-js has been patched because the community has started frequently encountered issues with "ingress expiry time" error messages. To help the community adopt this version, we need to incorporate it into ic-js. # Notes - Currently the ic-js released version use v2.0.0. - The patch of Agent-js consists of reverting a PR dfinity/agent-js#935. A suggested them to add a description. Meanwhile conversation on [Slack](https://dfinity.slack.com/archives/C020G13AS4F/p1727430471252989). # Changes - `npm run update:agent` --------- Signed-off-by: David Dal Busco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #923 due to a number of issues being reported
https://forum.dfinity.org/t/ingress-expiry-issue-your-input-needed/35609/2?u=peterparker
https://forum.dfinity.org/t/ingress-expiry-not-within-expected-range-error/35456/23?u=peterparker
https://forum.dfinity.org/t/frontend-canister-deployment-failing-for-ic-mainnet-timing-out/35378
Essentially, the agent attempts to reconcile the system time with the certified subnet time in order to compute the
ingress_expiryto send along with the request. This PR reverts any attempt to reconcile the differences while the team develops an approach that can allow agents to obtain the subnet time safely, without first making a certified read state call. More to come on this.