From 1e5e8053c851984b6aaa7e751232f27497a659f8 Mon Sep 17 00:00:00 2001
From: whikernel <whitekernel@whitekernel.fr>
Date: Sat, 9 Nov 2024 18:14:15 +0100
Subject: [PATCH] [ADD] Better visibility of commented elements

---
 .../blueprints/case/templates/modal_add_case_asset.html   | 2 +-
 .../blueprints/case/templates/modal_add_case_event.html   | 2 +-
 .../app/blueprints/case/templates/modal_add_case_ioc.html | 2 +-
 .../blueprints/case/templates/modal_add_case_rfile.html   | 2 +-
 .../blueprints/case/templates/modal_add_case_task.html    | 2 +-
 source/app/blueprints/case/templates/modal_note_edit.html | 2 +-
 source/app/static/assets/css/atlantis.css                 | 8 ++++++++
 7 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/source/app/blueprints/case/templates/modal_add_case_asset.html b/source/app/blueprints/case/templates/modal_add_case_asset.html
index 7b1283899..30f7b353b 100644
--- a/source/app/blueprints/case/templates/modal_add_case_asset.html
+++ b/source/app/blueprints/case/templates/modal_add_case_asset.html
@@ -20,7 +20,7 @@ <h4 class="modal-title mr-4">{{ "Asset #{}".format(asset.asset_id) if asset.asse
                          </div>
                          <button type="button" class="btn bg-transparent btn-xs" onclick="comment_element({{ asset.asset_id }}, 'assets')" title="Comments">
                             <span class="btn-label">
-                                <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length }}</span>
+                                <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length if comments_map|length > 0 else '' }}</span>
                             </span>
                         </button>
                         {% endif %}
diff --git a/source/app/blueprints/case/templates/modal_add_case_event.html b/source/app/blueprints/case/templates/modal_add_case_event.html
index f3ecfb92d..2a6d4fa21 100644
--- a/source/app/blueprints/case/templates/modal_add_case_event.html
+++ b/source/app/blueprints/case/templates/modal_add_case_event.html
@@ -28,7 +28,7 @@ <h4 class="modal-title mr-4">{% if event.event_id %} Event ID #{{ event.event_i
                     </div>
                     <button type="button" class="btn bg-transparent btn-xs" onclick="comment_element({{ event.event_id }}, 'timeline/events')" title="Comments">
                         <span class="btn-label">
-                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length }}</span>
+                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length if comments_map|length > 0 else '' }}</span>
                         </span>
                     </button>
                 {% endif %}
diff --git a/source/app/blueprints/case/templates/modal_add_case_ioc.html b/source/app/blueprints/case/templates/modal_add_case_ioc.html
index 410f5fd94..873e3a2f9 100644
--- a/source/app/blueprints/case/templates/modal_add_case_ioc.html
+++ b/source/app/blueprints/case/templates/modal_add_case_ioc.html
@@ -22,7 +22,7 @@ <h4 class="modal-title mr-4">{% if ioc.ioc_id %}Edit IOC #{{ ioc.ioc_id }}{% els
                      </div>
                      <button type="button" class="btn bg-transparent btn-xs" onclick="comment_element({{ ioc.ioc_id }}, 'ioc')" title="Comments">
                         <span class="btn-label">
-                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length }}</span>
+                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length if comments_map|length > 0 else '' }}</span>
                         </span>
                      </button>
                     {% endif %}
diff --git a/source/app/blueprints/case/templates/modal_add_case_rfile.html b/source/app/blueprints/case/templates/modal_add_case_rfile.html
index 9a13341d7..c345ced9d 100644
--- a/source/app/blueprints/case/templates/modal_add_case_rfile.html
+++ b/source/app/blueprints/case/templates/modal_add_case_rfile.html
@@ -20,7 +20,7 @@ <h4 class="modal-title mr-4">{% if rfile.id %}Edit evidence #{{rfile.id}}{% else
                      </div>
                     <button type="button" class="btn bg-transparent btn-xs" onclick="comment_element({{ rfile.id }}, 'evidences')" title="Comments">
                         <span class="btn-label">
-                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length }}</span>
+                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length if comments_map|length > 0 else '' }}</span>
                         </span>
                     </button>
                     {% endif %}
diff --git a/source/app/blueprints/case/templates/modal_add_case_task.html b/source/app/blueprints/case/templates/modal_add_case_task.html
index 78e03aa62..ec9432ffe 100644
--- a/source/app/blueprints/case/templates/modal_add_case_task.html
+++ b/source/app/blueprints/case/templates/modal_add_case_task.html
@@ -20,7 +20,7 @@ <h4 class="modal-title mr-4">{% if task.id %} Task ID #{{ task.id }}{% else %}
                  </div>
                  <button type="button" class="btn bg-transparent btn-xs" onclick="comment_element({{ task.id }}, 'tasks')" title="Comments">
                         <span class="btn-label">
-                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length }}</span>
+                            <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length if comments_map|length > 0 else '' }}</span>
                         </span>
                 </button>
                 {% endif %}
diff --git a/source/app/blueprints/case/templates/modal_note_edit.html b/source/app/blueprints/case/templates/modal_note_edit.html
index 64183792d..8cf1d04fa 100644
--- a/source/app/blueprints/case/templates/modal_note_edit.html
+++ b/source/app/blueprints/case/templates/modal_note_edit.html
@@ -15,7 +15,7 @@ <h4 class="modal-title mr-4">Note #{{ note.note_id }}</h4>
                 </button>
                 <button type="button" class="btn bg-transparent btn-xs" onclick="comment_element({{ note.note_id }}, 'notes')" title="Comments">
                     <span class="btn-label">
-                        <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length }}</span>
+                        <i class="fa-solid fa-comments"></i><span class="notification" id="object_comments_number">{{ comments_map|length if comments_map|length > 0 else '' }}</span>
                     </span>
                 </button>
                  <div class="dropdown">
diff --git a/source/app/static/assets/css/atlantis.css b/source/app/static/assets/css/atlantis.css
index 4d927e071..64641760c 100644
--- a/source/app/static/assets/css/atlantis.css
+++ b/source/app/static/assets/css/atlantis.css
@@ -16019,4 +16019,12 @@ td.dt-nowrap { white-space: nowrap }
 
 .radial-bg-primary {
     background: radial-gradient(#013479, #011d40) !important;
+}
+
+.notification:not(:empty).notification:not([text='0'])  {
+    background: #c40101;
+    color: white;
+    padding: 2px 5px 2px 5px;
+    border-radius: 50% 50%;
+    margin-bottom: 3px;
 }
\ No newline at end of file