Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] close_datetime for cases #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vladimir-A
Copy link
Contributor

Created a new row in the DB to store the case closing time value. The DB already has the case closing date, but we need a more accurate value.

@whikernel
Copy link
Contributor

Hi! Thanks - I think we could use the current field and do a migration from date to datetime.
So we don't have to change the underlying shema (marshmallow etc)

What do you think?

@Vladimir-A
Copy link
Contributor Author

Hi! Thanks - I think we could use the current field and do a migration from date to datetime. So we don't have to change the underlying shema (marshmallow etc)

What do you think?

Hi, that was my first thought, but I was afraid to break the internal logic tied to this field, so I made a new one. I agree that a more correct solution is to migration from date to datetime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants