Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The degree of compatibility with LibXC / other functionals #100

Open
andrewshyichuk opened this issue Oct 21, 2024 · 1 comment
Open

The degree of compatibility with LibXC / other functionals #100

andrewshyichuk opened this issue Oct 21, 2024 · 1 comment

Comments

@andrewshyichuk
Copy link

andrewshyichuk commented Oct 21, 2024

What is your suggested feature? Please describe.

The code requires libxc, it thus must call libxc. If it calls libxc for PW91 LDA - it can call it for any other LDA, am I right?
The same goes for GGA, and hybrids. Or, does it not?

Describe the solution you'd like

I'd like to use PBEsol at least, and general libxc input at best (e.g. XC_GGA_X_PBE_SOL+XC_GGA_C_PBE_SOL).

Edit
Modified the two files below, adding a functional was straightforward.
sktwocnt/lib/xcfunctionals.f90
sktwocnt/lib/twocnt.f90

Do I assume correctly that, from purely physical point of view, there is no fundamental difference in which GGA do I use? I mean, as long as the functional itself is sane, the SK files and the respective DFTB calculation would be sane as well?

@vanderhe
Copy link
Member

Hi @andrewshyichuk,

while slateratom and sktwocnt are interfaced with libXC, we only support a limited number of xc-functionals. An extension of this list in principle is straight-forward and requires changes to all three components: sktools, slateratom, and sktwocnt. So modifying the two files listed above does not suffice. I don't think we will support general libXC inputs any time soon, but adding e.g. PBEsol shouldn't be too involved.

Do I assume correctly that, from purely physical point of view, there is no fundamental difference in which GGA do I use?

Yes, that is correct. From a technical point of view one has to be careful, especially with hybrids as you are responsible to admix the correct amount of (range-separated) Fock exchange.

Best regards
Tammo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants