Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG sign releases (tags) #233

Open
Kixunil opened this issue Jan 10, 2020 · 3 comments
Open

GPG sign releases (tags) #233

Kixunil opened this issue Jan 10, 2020 · 3 comments

Comments

@Kixunil
Copy link

Kixunil commented Jan 10, 2020

Please sign the releases using GPG, so that people can verify authenticity of the code.

@NicolasDorier
Copy link
Member

@Kixunil my git commit are signed

@bitcoinbrisbane
Copy link
Contributor

Could we do it via CircleCI?

@Kixunil
Copy link
Author

Kixunil commented Jul 15, 2020

@bitcoinbrisbane you shouldn't. Signing should be an explicit operation that requires the author seeing the code and keeping the key safely stored.

@NicolasDorier just realized, there's a potential problem with signed commits: someone could present you a git repository with the version tag pointing at older, vulnerable version. It's easier to verify that the tag is recent than the commit being recent, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants