Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to display svg image for chat icon #48

Closed
vkhattar opened this issue Nov 15, 2017 · 3 comments
Closed

Unable to display svg image for chat icon #48

vkhattar opened this issue Nov 15, 2017 · 3 comments

Comments

@vkhattar
Copy link

Unable to render the svg image for chat icon. When I changed the image to a png image it worked properly, unfortunately I will not be able ship it with my changes.

Another suggestion here, just like how there is a slack image option for props, can we have something like that for this as well ?

Any help will be appreciated. Thanks.

How image tag looks like with svg -
<img class="sc-closed-icon" src="/58a15de4005b6706fd064d5778a80c4e.svg">

How image tag looks like with png -
<img class="sc-open-icon" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAfCAMAAACxiD++AAAABGdBTUEAALGPC/xhBQAAAAFzUkdCAK7OHOkAAAAtUExURUxpcf///////////////////////////////////////////////////////3EAnbYAAAAOdFJOUwADZ66SoQjEhnS7/gsNGQL7+wAAAKtJREFUKM+F01sOhCAQRNESFV/I/pc70Og0YJfyJbmHhBAbGGYHstw8IPV4EOGOmERYIhGpxyUAJxHSz/xlC+1FxE64qB1yj1ZID7oXsel+63ovnj2JXUXue+hvrcLugL+EdG+9XBG8X+Kl34J3YM1g/egvIvdx5EK691RIz78YEXdnQrst6m6JqemXmNo+D/WJNAyVePZWWL0WdlfB+l+UAQQReaAc65DB/wGsZgzLN0IQWAAAAABJRU5ErkJggg==">

@dharness
Copy link
Owner

dharness commented Nov 15, 2017

I'm not sure what you mean. You are trying to change the icon on the launcher?

We can consider that -- but just so you know all of these changes (if we do decide to implement them) won't make their way into a release for many months. If you want to make a PR, that would expedite the process.

@vkhattar
Copy link
Author

vkhattar commented Nov 15, 2017

aah i see what you mean, I can probably work on it as well. But this one is the most important for me as I am unable to get the chat icon image to be rendered. Ill add an image to show you what i mean.

This image is not being rendered properly :/

screenshot 2017-11-15 12 54 29

Close button appears as its a png file

screenshot 2017-11-15 13 04 32

@heatherbooker
Copy link
Contributor

I'm not sure if this is related to #68, but the SVG displays alright in the demo on github pages as well as locally for me on chrome/firefox/safari. If you can provide more information and/or a reproduction we'll be happy to re-investigate and try to help solve this - sorry we can't offer more help at this point! ><

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants