Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of nwb build tool #128

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove use of nwb build tool #128

wants to merge 6 commits into from

Conversation

heatherbooker
Copy link
Contributor

Closes #93 - Move away from nwb, the magical build tool.

  • Add npm keywords for users to find the package more easily
  • Replace nwb with webpack and babel
  • Use two separate webpack configs for demo vs. actual component
  • Move devDependencies where they belong
  • Remove the unused react-highlight.js package

@dharness Can you have a good look? I'm not entirely confident about this.

@dharness
Copy link
Owner

@heatherbooker there's got to be a way to publish from a branch to npm and see if we can install it - that would give me a lot more confidence

@dharness
Copy link
Owner

This is nice 👍 I'm going to have to checkout and try it to confirm it all works though

@heatherbooker
Copy link
Contributor Author

there's got to be a way to publish from a branch to npm and see if we can install it - that would give me a lot more confidence

Yeah eh? Agreed. Maybe npm pack, scroll down here? https://medium.com/@vcarl/problems-with-npm-link-and-an-alternative-4dbdd3e66811

@heatherbooker
Copy link
Contributor Author

heatherbooker commented Oct 4, 2019

@dharness Could you check this one out again? (rebased to fix conflicts, would like to mergeeeee)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from nwb
3 participants