Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to make argument ordering consistent in functions with similar signatures #154

Open
dhermes opened this issue Oct 24, 2019 · 0 comments
Open

Attempt to make argument ordering consistent in functions with similar signatures #154

dhermes opened this issue Oct 24, 2019 · 0 comments
Assignees
@dhermes
Labels
hygiene language: fortran language: python type: enhancement

Comments

@dhermes
Copy link
Owner

dhermes commented Oct 24, 2019

See: #146 (comment)

...it is also slightly jarring that the argument order of evaluate_hodograph and get_curvature (for example) are not consistent: the former takes s before the nodes, whereas the latter takes the nodes before s.

  • def _evaluate_hodograph(s, nodes): ref
  • def _get_curvature(nodes, tangent_vec, s): ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
hygiene language: fortran language: python type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhermes