Bounds checks for many fields #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholroyd
force-pushed
the
bitstream-restrictions-bounds-checks
branch
from
549d4e6 to
902104e
Compare
dholroyd
changed the title
dholroyd
force-pushed
the
bitstream-restrictions-bounds-checks
branch
from
902104e to
86a0ff9
Compare
dholroyd
force-pushed
the
bitstream-restrictions-bounds-checks
branch
from
86a0ff9 to
506ee23
Compare
|
| Report | Fri, March 1, 2024 at 07:28:22 UTC |
| Project | h264-reader |
| Branch | 66/merge |
| Testbed | ubuntu-22.04 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | Instructions | Instructions Results instructions | L1 Accesses | L1 Accesses Results accesses | L2 Accesses | L2 Accesses Results accesses | RAM Accesses | RAM Accesses Results accesses | Total Accesses | Total Accesses Results total-accesses |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24f... | ➖ (view plot) | 16653199.000 | ➖ (view plot) | 8205418.000 | ➖ (view plot) | 10769774.000 | ➖ (view plot) | 16841.000 | ➖ (view plot) | 165692.000 | ➖ (view plot) | 10952307.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
dholroyd
force-pushed
the
bitstream-restrictions-bounds-checks
branch
from
506ee23 to
bacebcc
Compare
dholroyd
force-pushed
the
bitstream-restrictions-bounds-checks
branch
from
bacebcc to
ab5c4cb
Compare
|
| Report | Fri, March 1, 2024 at 18:56:06 UTC |
| Project | h264-reader |
| Branch | 66/merge |
| Testbed | localhost |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Lower Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | L1 Accesses | L1 Accesses Results accesses | L2 Accesses | L2 Accesses Results accesses | RAM Accesses | RAM Accesses Results accesses | Total Accesses | Total Accesses Results total-accesses |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24f... | ✅ (view plot) | 16648266.000 (+0.04%) | 14976912.000 (89.96%) | ➖ (view plot) | 8205445.000 | ➖ (view plot) | 10771081.000 | ➖ (view plot) | 15558.000 | ➖ (view plot) | 165697.000 | ➖ (view plot) | 10952336.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out to be more complicated than I expected due to the need to refer to a table of values from the spec when calculating the max value for
max_dec_frame_buffering.log2_max_mv_length_horizontalandlog2_max_mv_length_verticalare not checked to the [0, 15] limits in the most recent spec because older specs said the restriction was [0, 16] and real world test data appears to use the value 16.Other changes included,
Fixes #55 and #58