From 60a7071582a30385a4e91d582249a7bb8be37819 Mon Sep 17 00:00:00 2001 From: mrister Date: Mon, 6 Nov 2017 13:17:03 +0100 Subject: [PATCH 1/2] Update dependencies and add a test to verify a brazilian mobile number Currently the old version og googlelibhonenumber returns unknown for a mobile type for a Brazilian phone number and updating it will fix the problem. --- package.json | 6 +++--- tests/unit/node-phone-utils.spec.js | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index f725f55..41d50f1 100644 --- a/package.json +++ b/package.json @@ -37,11 +37,11 @@ "dependencies": { "cache-manager": "^2.0.1", "dotenv": "^2.0.0", - "google-libphonenumber": "^1.0.16", + "google-libphonenumber": "^3.0.7", "lodash": "^4.6.0", "node-hlr-client": "^0.0.13", - "node-uuid": "^1.4.7", - "smsapicom": "^1.2.0" + "smsapicom": "^1.2.0", + "uuid": "^3.1.0" }, "engine": "node >= 5.6.0", "devDependencies": { diff --git a/tests/unit/node-phone-utils.spec.js b/tests/unit/node-phone-utils.spec.js index 2a6bcaf..c8df979 100644 --- a/tests/unit/node-phone-utils.spec.js +++ b/tests/unit/node-phone-utils.spec.js @@ -158,6 +158,10 @@ describe('Phone Number Utils', function initialTests() { expect(phoneUtils.getType(testMobilePhoneNumber.number, testMobilePhoneNumber.regionCode)).to.be.a('number').and.to.eql(phoneUtils.PhoneNumberType.MOBILE); }); + it('should get type of valid Brazil mobile phone number to be mobile', function () { + expect(phoneUtils.getType('+5541987960672')).to.be.a('number').and.to.eql(phoneUtils.PhoneNumberType.MOBILE); + }); + it('should get type of valid phone number without region code', function () { expect(phoneUtils.getType(testPhoneNumber.number)).to.be.a('number'); }); From 16ec3931ffcf500f86b708b3bf663835391fad3b Mon Sep 17 00:00:00 2001 From: mrister Date: Mon, 6 Nov 2017 15:10:42 +0100 Subject: [PATCH 2/2] Bump version to 2.1.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 41d50f1..7653bbe 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-phone-utils", - "version": "2.1.0", + "version": "2.1.1", "description": "Phone number utils library", "main": "lib/index.js", "scripts": {