Do not suppress 0 values #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 is a valid value for a gauge or a counter (e.g. "number of active sessions" can easily be zero and that state is distinct from is distinct 1) and zero samples in a period is legit for a histogram over an interval. For gauges we should also not reset to zero on each render, but we should continue to do so for counters. Suppression of idle metrics should be done using `StatsdBuilder::idle_timeout`. Fixes dialtone#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 is a valid value for a gauge or a counter (e.g. "number of active sessions"
can easily be zero and that state is distinct from is distinct 1) and zero
samples in a period is legit for a histogram over an interval.
For gauges we should also not reset to zero on each render, but we should
continue to do so for counters.
Suppression of idle metrics should be done using
StatsdBuilder::idle_timeout.Fixes #5 (at least in line with my opinion in #5 (comment)).