[TASK] Split error handling for settings

die-wegmeister · Dec 4, 2023 · bb3d1e1 · bb3d1e1
1 parent a46ea00
commit bb3d1e1
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Classes/RequestMethod/CurlPostWithProxy.php b/Classes/RequestMethod/CurlPostWithProxy.php
@@ -59,9 +59,12 @@ public function injectSettings(array $settings)
             throw new \Exception("Missing configuration, please add the following settings: 'Wegmeister.Recaptcha.httpProxy'");
         }
 
+        if(!is_string($settings['httpProxy'])){
+            throw new \Exception("Invalid configuration, the Wegmeister.Recaptcha.httpProxy option has to be a string.");
+        }
+
         $httpProxyParts = explode(':', $settings['httpProxy']);
-        // check if the settings is a string & has exactly two parts & the port only contains numbers
-        if(!is_string($settings['httpProxy']) || count($httpProxyParts) !== 2 || (int)$httpProxyParts[1] === 0){
+        if(count($httpProxyParts) !== 2 || (int)$httpProxyParts[1] === 0){
             throw new \Exception("Invalid configuration, the Wegmeister.Recaptcha.httpProxy option should have the following format: 'http://yourproxy.com:1234'");
         }