Backports/2.1.4

[1Dragoon]

Hopefully I'm doing this correctly:

• Fix impl SqlOrd postgres > postgres_backend feature flag.
• Allow Queryable to be used with multiple table names
• Fix chrono deprecation warnings
• Adjusted some unit tests to reflect chrono changes

Note: One unit test is failing, but I'm uncertain whether it's caused by my local build environment. It was already failing without any of these changes.

failures:

---- pg::expression::extensions::interval_dsl::tests::intervals_match_pg_values_f64 stdout ----
thread 'pg::expression::extensions::interval_dsl::tests::intervals_match_pg_values_f64' panicked at /home/1Dragoon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quickcheck-1.0.3/src/tester.rs:165:28:
[quickcheck] TEST FAILED. Arguments: (-2578.740551172832)

[1Dragoon]

So this is odd, clippy is tossing lints about chrono deprecated methods, yet chrono 0.4.20 doesn't have the replacement methods. Bumping chrono to anything higher (even from 0.4.20 to 0.4.21) results in a libc conflict in the compile tests, which can't be resolved because r2d2 has a parking_lot dependency that requires a lower version than what chrono and time require.

It does look like r2d2 has an interest in removing parking_lot according to this: sfackler/r2d2#140

[weiznich]

Thanks for opening this PR.
For the chrono issues I would prefer to pull in the relevant changes from the master branch:

#3953
and
4c7b6ea

That should hopefully resolve those issues without changing the minimal supported chrono version and prevent that breaking change.

[1Dragoon]

Sure, merged those in. The CI is failing here still:

I've seen this before. In my local setup I had to fix this by modifying ./bin/test to specify the db type as a feature directly, maybe the CI needs to be adjusted somehow?

Here are the specific changes: https://github.com/diesel-rs/diesel/pull/3959/files#diff-4e821476d5e4f5626c6f9fca337a47afe96a5e3daf23bccb02ad0bb109a9a407

Also note that in my local setup, mysql is failing numerous tests, but I'm not sure the cause as I just used the docker-compose method mentioned in the contributor document. Everything else works fine.

[1Dragoon]

No matter what I do I can't seem to get the MSRV to pass

[weiznich]

I pushed another commit that hopefully fixes the MSRV build. Will try to do a final review and a release tomorrow.

[weiznich]

Published as https://github.com/diesel-rs/diesel/releases/tag/v2.1.5

Thanks again for your work on the backports.