Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious warnings in proof of s2n-tls function s2n_stuffer_read_hex() #8427

Open
rod-chapman opened this issue Aug 27, 2024 · 0 comments
Open
Labels
aws Bugs or features of importance to AWS CBMC users

Comments

@rod-chapman
Copy link
Collaborator

CBMC version: "develop" branch commit c193c27, built on 27th August 2024
Operating system: EC2/Ubuntu Linux
Exact command line resulting in the issue: "make result"
What behaviour did you expect: Successful proof with 0 warnings and 0 errors.
What happened instead: 2 warnings, possibly spurious.

Proof of the function s2n_stuffer_read_hex() from the fork at https://github.com/rod-chapman/s2n-tls,
on branch "unbound_stuffer_read_hex" at commit [e307312].

Proof succeeds OK, but generates two confusing warnings:

file <builtin-library-tolower> line 4:  'tolower'
old definition in module s2n_blob file /usr/include/ctype.h line 122
signed int (signed int __c, __CPROVER_contracts_write_set_ptr_t __write_set_to_check)
new definition in module <built-in-library> file <builtin-library-tolower> line 4
signed int (signed int c)

file <builtin-library-strcasecmp> line 9:  'strcasecmp'
old definition in module s2n_errno file /usr/include/strings.h line 116
signed int (const char *__s1, const char *__s2, __CPROVER_contracts_write_set_ptr_t __write_set_to_check)
new definition in module <built-in-library> file <builtin-library-strcasecmp> line 9
signed int (const char *s1, const char *s2)

It is rather non-obvious what's going wrong here, and if these really are a problem or not. Will cause confusion and anxiety for users.

@rod-chapman rod-chapman added the aws Bugs or features of importance to AWS CBMC users label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users
Projects
None yet
Development

No branches or pull requests

1 participant