You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A bug can arise if steps 2 or 3 fail, or if step 1 succeeds on the server but fails on the client (likely due to network failure). If this happens, trying to re-add the server will fail because the server will respond with “you can’t do this, we already have this project”.
To fix this, we should make adding a project idempotent on the server side.
That means:
Changing POST /projects to PUT /projects (careful about backwards compatibility with existing builds)
It should be easy to change POST /projects to PUT /projects, so this work is mostly done. I plan to wait until November 1 to make this change, as it's a breaking change that would affect our COP16 demos.
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this issue
Oct 23, 2024
Adding a server peer basically has 3 steps:
A bug can arise if steps 2 or 3 fail, or if step 1 succeeds on the server but fails on the client (likely due to network failure). If this happens, trying to re-add the server will fail because the server will respond with “you can’t do this, we already have this project”.
To fix this, we should make adding a project idempotent on the server side.
That means:
POST /projects
toPUT /projects
(careful about backwards compatibility with existing builds)See the equivalent issue on
@comapeo/core
: digidem/comapeo-core#916.The text was updated successfully, but these errors were encountered: