Sync/ Device discovery inconsistent

[ximenabb]

Details : https://www.notion.so/digidem/Sync-Device-discovery-inconsistent-10c1b08162d580099a26fdeb94138c5c

[EvanHahn]

I can't reproduce this issue on the backend. I wrote this test to simulate the bug we were seeing:

test('issue 872', async (t) => {
  const managerCount = 4

  const managers = await createManagers(managerCount, t)
  const [invitor, ...invitees] = managers

  const disconnectPeers = connectPeers(managers)
  t.after(disconnectPeers)

  const projectId = await invitor.createProject({ name: 'Mapeo' })
  await invite({ invitor, invitees, projectId })

  const projects = await Promise.all(
    managers.map((m) => m.getProject(projectId))
  )
  await waitForSync(projects, 'initial')

  for (const project of projects) {
    const { remoteDeviceSyncState } = project.$sync.getState()
    const otherDevices = Object.keys(remoteDeviceSyncState).length
    assert.equal(otherDevices, managerCount - 1)
  }
})

I don't think this test is worth including because it's so specific, but I tweaked an existing test in #964.

Either this is no longer a bug, it's a frontend-only bug, or the bug exists elsewhere.

[EvanHahn]

Andrew was still able to reproduce this. I was hopeful that we'd fixed it, but alas.