Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to @comapeo/[email protected] #744

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

EvanHahn
Copy link
Contributor

I haven't yet tested this manually.

Fixes #671.

@gmaclennan
Copy link
Member

The hypercore transitive dep is still wrong unfortunately. Just away from my desk but I can fix when I'm back. I think you need to uninstall Mapeo core then re-install to force the package-lock to dedupe to the hypercore 10.17 version.

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, I was looking at the wrong package-lock.json (the one for the frontend, rather than the backend). The file src/backend/package-lock-json only has the correct version of hypercore, v10.17.0.

image

We should at some point address how to use types from the backend in the front-end without bringing all the dependencies with them.

Side-note: this is a case-in-point for digidem/comapeo-core#841. Updating @mapeo/core in the frontend resulted in the pinned version of corestore, but still kept two versions of hypercore. In the backend we were ok for some reason, but could have had this issue. Npm lockfiles (and dependencies in any programming language) are a headache!

image

(frontend npm list hypercore showing above, can be ignored because I don't think we bundle it anyway)

@gmaclennan
Copy link
Member

Let's get this tested manually before merging. I can't test until about 10am EDT.

@EvanHahn
Copy link
Contributor Author

Tested this manually and it looks good.

Merging.

@EvanHahn EvanHahn merged commit 9b121f0 into develop Sep 19, 2024
3 checks passed
@EvanHahn EvanHahn deleted the update-to-comapeo-core-1.0.1 branch September 19, 2024 13:09
EvanHahn added a commit that referenced this pull request Sep 19, 2024
Fixes [#671].

[#671]: #671

(cherry picked from commit 9b121f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Invite/ Invitee accepts invite but doesnt see its in the project
2 participants