Skip to content

Commit

Permalink
feat!: make observation location optional
Browse files Browse the repository at this point in the history
This is a partial revert of 4ce47f0.

It turns out that observations can, in edge cases, lack a location. This
makes its `lat` and `lon` fields optional.
  • Loading branch information
EvanHahn committed Aug 29, 2024
1 parent 3a18ded commit 430dab0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions proto/observation/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ message Observation_1 {

Common_1 common = 1;

double lat = 5;
double lon = 6;
optional double lat = 5;
optional double lon = 6;

// ATTACHMENT
enum AttachmentType {
Expand Down
2 changes: 1 addition & 1 deletion schema/observation/v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,6 @@
"required": ["docId", "versionId"]
}
},
"required": ["schemaName", "tags", "attachments", "lat", "lon"],
"required": ["schemaName", "tags", "attachments"],
"additionalProperties": false
}

0 comments on commit 430dab0

Please sign in to comment.