chore!: rename Attachment.driveId to Attachment.driveDiscoveryId #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
approved these changes
Sep 27, 2023
achou11
changed the title
tomasciccola
approved these changes
Sep 27, 2023
achou11
force-pushed
the
ac/drive-discovery-id
branch
from
ed40a8f to
505e9c1
Compare
This was referenced Sep 28, 2023
This was referenced Oct 25, 2023
This was referenced Aug 1, 2024
This was referenced Aug 24, 2024
This was referenced Sep 2, 2024
This was referenced Sep 16, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards digidem/comapeo-core#272
My understanding from the issue is that we want to rename this, but not entirely sure 😄