Feat: add Icon schema #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasciccola
commented
Oct 2, 2023
| large = 2; | ||
| } | ||
|
|
||
| enum PixelDensity { |
There was a problem hiding this comment.
this is horrible but you can't use numbers as elements of an enum
There was a problem hiding this comment.
ha! I guess so, maybe align the field numbers for sanity?
There was a problem hiding this comment.
enums must start at 0 :'|
There was a problem hiding this comment.
does it work if you do something like 1x, 2x (or maybe x1, x2)? not sure if any better but just an idea
There was a problem hiding this comment.
yeah, the second option works. I'm adding it since its less confusing to look at...
tomasciccola
commented
Oct 2, 2023
gmaclennan
approved these changes
Oct 3, 2023
| large = 2; | ||
| } | ||
|
|
||
| enum PixelDensity { |
There was a problem hiding this comment.
ha! I guess so, maybe align the field numbers for sanity?
gmaclennan
approved these changes
Oct 3, 2023
Co-authored-by: Gregor MacLennan <[email protected]>
Co-authored-by: Gregor MacLennan <[email protected]>
in protobufs, enums need to start at 0, so we can't align the numbers...
gmaclennan
approved these changes
Oct 3, 2023
This was referenced Oct 3, 2023
This was referenced Oct 25, 2023
This was referenced Aug 1, 2024
This was referenced Aug 24, 2024
This was referenced Sep 2, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would close #149
Default values have been set as:
mimeType: 'svg'
pixelDensity: 1,
size: 'small'
Should tests for
Iconbe added on this ticket??