chore: move typedoc-related deps to dev deps #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
approved these changes
Aug 14, 2024
|
deaamnn |
This was referenced Aug 24, 2024
This was referenced Sep 2, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://pkg-size.dev/@mapeo%[email protected], I think including
typedocis including a pinned version of typescript as a direct/peer dep, which causes installation for any module consuming @mapeo/schema to be incredibly slow (basically it's installing TS v5.1 alongside whatever TS version you've specified for yourself at the top level e.g. in an application project).My understanding is that typedoc and any relevant plugins are only used at build-time, so it would make more sense for these to be defined as dev dependencies