Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check code with ESLint #243

Merged
merged 9 commits into from
Oct 2, 2024
Merged

test: check code with ESLint #243

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d39d786
test: check code with ESLint
EvanHahn Sep 3, 2024
bd76d22
test: check code with ESLint
EvanHahn Sep 3, 2024
c537e51
Merge branch 'main' into add-eslint
EvanHahn Sep 12, 2024
648f526
Prefer `@ts-expect-error` to an `any` cast
EvanHahn Sep 12, 2024
fd2d518
Merge branch 'main' into add-eslint
EvanHahn Sep 25, 2024
eabe017
Remove _ prefix for unused variables
EvanHahn Sep 25, 2024
43873c6
Merge remote-tracking branch 'origin/add-eslint' into add-eslint
EvanHahn Sep 25, 2024
b1e28d4
Revert ts-expect-error
EvanHahn Sep 25, 2024
9afc5a1
Merge branch 'main' into add-eslint
EvanHahn Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import globals from 'globals'
import pluginJs from '@eslint/js'
import tseslint from 'typescript-eslint'

export default [
{ files: ['**/*.{js,mjs,cjs,ts}'] },
{ languageOptions: { globals: globals.node } },
pluginJs.configs.recommended,
...tseslint.configs.recommended,
{
ignores: ['dist/', 'generated/', 'intermediate/'],
},
{
rules: {
'@typescript-eslint/ban-ts-comment': [
'error',
{
'ts-expect-error': false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default still allows this, but makes us leave a comment.

},
],
'@typescript-eslint/no-explicit-any': 'off',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use a lot of anys so I don't think we should disable this right now.

'@typescript-eslint/no-unused-vars': [
'error',
{
varsIgnorePattern: '^_',
argsIgnorePattern: '^_',
},
],
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches rules we have elsewhere.

},
]
Loading
Loading