chore: remove ts-ignore and ts-expect-error
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no user impact. There's almost always something better than `// @ts-ignore` and `// @ts-expect-error`. They can be problematic because they're very broad, and typically broader than we want. For details, see ["At least 7 reasons to avoid @ts-expect-error and @ts-ignore"][0]. This removes all of them in favor of more targeted solutions. (Or, in one case, just removes it and everything was fine!) I think this is a useful change on its own, but it should make [an upcoming change][1] easier too. [0]: https://shane-o.dev/articles/any-or-expect [1]: https://github.com/digidem/mapeo-schema/pull/243
gmaclennan
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Looks ok with me. I'm in favour of just sticking // @ts-ignore in there when developing initial versions - sometimes jumping through hoops to get typescript passing can be a waste of dev time, especially in scenarios when TS just can't figure things out - however cleaning this up at a later stage like now is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #244.
This change should have no user impact.
There's almost always something better than
// @ts-ignoreand// @ts-expect-error. They can be problematic because they're very broad, and typically broader than we want. For details, see "At least 7 reasons to avoid @ts-expect-error and @ts-ignore".This removes all of them in favor of more targeted solutions. (Or, in one case, just removes it and everything was fine!)
I think this is a useful change on its own, but it should make an upcoming change easier too.