test: test validating a schema name that could "trick" JavaScript #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we intended to test the validation of bad docs but weren't doing so correctly. This fixes that.
I was worried that bad schema names like `hasOwnProperty` or `constructor` could cause trouble. They don't (as far as I can tell) but I still think it's worth adding a fixture for it.
EvanHahn
force-pushed
the
validate-hasownproperty
branch
from
8e10bc7 to
51bca96
Compare
gmaclennan
approved these changes
Sep 4, 2024
gmaclennan
added a commit
that referenced
this pull request
Sep 9, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was worried that bad schema names like
hasOwnPropertyorconstructorcould cause trouble. They don't (as far as I can tell) but I still think it's worth adding a fixture for it.