Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make CoreOwnership core IDs required #258

Merged
merged 1 commit into from
Sep 16, 2024
Merged

chore: make CoreOwnership core IDs required #258

merged 1 commit into from
Sep 16, 2024

Conversation

EvanHahn
Copy link
Contributor

This change:

  • Marks all CoreOwnership core IDs required in the proto
  • Gives each core ID a minimum length in the schema
  • Validates this length when decoding
  • Adds a test for the above

@EvanHahn
chore: make CoreOwnership core IDs required
fa5ed3d 
This change:

- Marks all `CoreOwnership` core IDs `required` in the proto
- Gives each core ID a minimum length in the schema
- Validates this length when decoding
- Adds a test for the above
@EvanHahn EvanHahn marked this pull request as ready for review September 16, 2024 02:23
@EvanHahn EvanHahn requested a review from gmaclennan September 16, 2024 02:23
@EvanHahn EvanHahn mentioned this pull request Sep 16, 2024
Merged
@EvanHahn EvanHahn merged commit 3f44efb into main Sep 16, 2024
6 checks passed
@EvanHahn EvanHahn deleted the coreownership-coreids-required branch September 16, 2024 16:04
This was referenced Sep 16, 2024
Merged
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanHahn @gmaclennan