Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not make sens to compare V1 and V2 LF versions #20101

Open
remyhaemmerle-da opened this issue Oct 15, 2024 · 0 comments
Open

Does not make sens to compare V1 and V2 LF versions #20101

remyhaemmerle-da opened this issue Oct 15, 2024 · 0 comments

Comments

@remyhaemmerle-da
Copy link
Collaborator

com.digitalasset.daml.lf.language.LanguageVersion#Ordering compare V1 and V2 LF Version.

It does not really make sens to compare V1 and V2 version, so we better should drop this Ordering in favor of the comparison of minor LF version only.
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Oct 15, 2024
Merged
remyhaemmerle-da added a commit that referenced this issue Oct 15, 2024
@remyhaemmerle-da
Make the comparison of LF version total (#20102)
7bc65fd 
This quick fix addresses a crash issue when comparing V1 with V2 LF Versions unexpectedly.
In the future, we should consider removing this ordering altogether. See issue #20101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remyhaemmerle-da