Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value normalization is wrong, and translation in IDE Ledger doesn't follow #20468

Open
samuel-williams-da opened this issue Dec 12, 2024 · 2 comments
Open

Value normalization is wrong, and translation in IDE Ledger doesn't follow #20468

samuel-williams-da opened this issue Dec 12, 2024 · 2 comments
Assignees
@samuel-williams-da

Comments

@samuel-williams-da
Copy link
Contributor

samuel-williams-da commented Dec 12, 2024 •
edited
Loading

Value normalization was changed to drop trailing fields in templates/records from upgradable packages, about a month ago.
This however, does not correctly handle exerciseByInterface calls, which should decide the dropping of fields based solely on the interface version.

On top of this, the ValueTranslator does not have this logic, leading to failures in the IDE Ledger which are affecting daml-finance
@samuel-williams-da samuel-williams-da self-assigned this Dec 12, 2024
@samuel-williams-da samuel-williams-da mentioned this issue Dec 13, 2024
Merged
@mziolekda
Copy link
Contributor

Tracked on the release board through:
https://github.com/DACH-NY/assembly/issues/610

@samuel-williams-da
Copy link
Contributor Author

Fixed by #20473 in 2.x

paulbrauner-da added a commit that referenced this issue Dec 17, 2024
@paulbrauner-da
reproduce #20468
f03221d
paulbrauner-da added a commit that referenced this issue Dec 17, 2024
@paulbrauner-da
reproduce #20468
8c05df9
paulbrauner-da added a commit that referenced this issue Dec 17, 2024
@paulbrauner-da
mixed LF versions tests (#20497)
1da3a35 
* reproduce #20468

* test user defined 1.15 tuple

* add tests for non-dynamic choices

* add type tetris test

* upgrade payload of mixed lf versions

* fix bug

* rename package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuel-williams-da samuel-williams-da

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mziolekda @samuel-williams-da