Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default new format issuer instance to not include created. #180

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

dlongley
Copy link
Member

  • Allow optional created to be included via includeCreated cryptosuite option.

- Allow optional `created` to be included via `includeCreated`
  cryptosuite option.
@dlongley
Copy link
Member Author

Addresses #178.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (2863936) to head (a9816e9).

Files with missing lines Patch % Lines
lib/suites.js 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   90.75%   90.80%   +0.04%     
==========================================
  Files          17       17              
  Lines        3235     3250      +15     
==========================================
+ Hits         2936     2951      +15     
  Misses        299      299              
Files with missing lines Coverage Δ
schemas/bedrock-vc-issuer.js 100.00% <100.00%> (ø)
lib/suites.js 81.17% <82.60%> (+0.92%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2863936...a9816e9. Read the comment docs.

@dlongley dlongley merged commit 8134770 into main Sep 23, 2024
4 checks passed
@dlongley dlongley deleted the created-option branch September 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants