Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s7 enumerate Read_SZL defined twice #15

Open
stze opened this issue Aug 23, 2016 · 0 comments
Open

s7 enumerate Read_SZL defined twice #15

stze opened this issue Aug 23, 2016 · 0 comments

Comments

@stze
Copy link

stze commented Aug 23, 2016

I've noticed that the same packet is defined twice in the s7-enumerate.nse script.

 -- setup the Read SZL information packet
  local Read_SZL = bin.pack("H", "0300002102f080320700000000000800080001120411440100ff09000400110001")
  -- setup the first SZL request (gather the basic hardware and version number)
  local first_SZL_Request = bin.pack("H", "0300002102f080320700000000000800080001120411440100ff09000400110001")
  -- setup the second SZL request

variable Read_SZL is the same as first_SZL_Request. Maybe the script code is easier to read with only one local variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stze