Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke existing cards via HTTP endpoint #1415

Closed
ztefanie opened this issue Apr 29, 2024 · 2 comments · Fixed by #1674
Closed

Revoke existing cards via HTTP endpoint #1415

ztefanie opened this issue Apr 29, 2024 · 2 comments · Fixed by #1674
Assignees
Milestone

Comments

@ztefanie
Copy link
Member

ztefanie commented Apr 29, 2024

Is your feature request related to a problem? Please describe.
Adjust the existing HTTP PUT endpoint, so it will revoke existing cards, when the expiration date is set to a date in the past.

Describe the solution you'd like

  • Check if a entry in the csv has expiration date in the past
  • find the card that is associated with this entry
  • revoke the card

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
For testing:

  • Upload a csv with a valid user info
  • activate the card in the app
  • upload a csv with the same user info, but an expiration date in the past
  • open the app: The card should no longer work
@ztefanie ztefanie added the Task label Apr 29, 2024
@ztefanie ztefanie added this to the Koblenz Pass milestone Apr 29, 2024
@f1sh1918 f1sh1918 added koblenz blocked Task or user story can not be continued at the moment labels Jul 29, 2024
@f1sh1918 f1sh1918 added blocked Task or user story can not be continued at the moment and removed blocked Task or user story can not be continued at the moment labels Aug 28, 2024
@f1sh1918
Copy link
Contributor

@ztefanie i'm not pretty sure if we really need #1419 and #1431 for this.
I think this function will be triggered after each csv import and should just set the card revoked = true . We can just create a proper backend test for testing this.
If the card was activated or not is not important.
In the frontend we already can test the case if a card is revoked that it can't be activated or used. Even we can not test that for koblenz at the moment, i think we can start this task after #1424

@ztefanie
Copy link
Member Author

@f1sh1918 sure feel free to adjust/edit the text. I like testing issues and everything connected to it, when developing and see no real point of doing this before the other tickets, but feel free to do so, if you have a strong opinion on this.

@seluianova seluianova self-assigned this Sep 23, 2024
@seluianova seluianova moved this to In Progress in entitlementcard Oct 7, 2024
@f1sh1918 f1sh1918 removed the blocked Task or user story can not be continued at the moment label Oct 16, 2024
@seluianova seluianova linked a pull request Oct 17, 2024 that will close this issue
@seluianova seluianova moved this from In Progress to In Review in entitlementcard Oct 21, 2024
@steffenkleinle steffenkleinle moved this to In Review in team-app Oct 22, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in team-app Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants