-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create createCard endpoint #1421
Comments
just got a sudden idea. |
Its a good idea but we have lots of existing functionality in the "administration" like the card extensions, deeplinks which we can reuse. Further more we could also provide additionally a pdf if a service user supports a user that can not create the card by him/herself and just pass the pdf to him/her. Normal use case is that the user doesn't have to scan or download the pdf but just create the card and then click a button with a Normal Process:
|
@f1sh1918 is a no-way-but or to be discussed?
is it bad if we won't have to? I assumed it could mean for us to do less, not more (or am I missing something?)
is it applicable to Koblenz? is it something that an unauthorized user does? (I'm not familiar with this process)
is it a plausible case when the form has 3 fields?
right, but still an extra layer and extra browser interaction. |
Just found an answer here #1430 and it seems to me that both actions could be potentially done through the app |
I think we discussed the process we gonna go with the customer. All projects have a separate "beantragen" function in the browser. Even in this case it wouldn't be as much effort as in the other cases to do that in the app we have to build a special case for Koblenz. If we move the function in the app we can not easily use the pdf creation and we might need that as a backup. There will be people that won't be able to create their card by themselves. Additionally we have an easy extendable card configuration in the administration where we already have All fields with validation except the referenceNumber which we can reuse. With my opened config pr you can already create a valid card f.e. You can just reuse that function in the Portal and adjust some small things. The additional effort to move that to the native app is not that small if we build it generic and extendible. Create the input fields, make validation, show hints. Do the protobuf checks (sufficient space) before we send the data to card creation. I would suggest to create an separate improvement issue. We might adjust that at a later point when there may be other customers with a similar creation process #1430 will be done in the app yes but we don't need input fields because the data is already in the app |
Ah and one thing I forgot was that we should keep the possibility to create a static printed pass, therefore we need the pdfs |
Couple more questions:
|
Is your feature request related to a problem? Please describe.
Create a new endpoint (or adjust existing one) that receive the user data from the self service portal
Describe the solution you'd like
Describe alternatives you've considered
We could extend the current createCard mutation and allow creating without jwt token if its a particular projectId (not sure if that is secure enough)
blocked by #1499
The text was updated successfully, but these errors were encountered: