Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freinet agency information #1762

Open
ztefanie opened this issue Nov 7, 2024 · 4 comments · May be fixed by #1902
Open

Add freinet agency information #1762

ztefanie opened this issue Nov 7, 2024 · 4 comments · May be fixed by #1902
Assignees
Labels
backend Task involves making changes to the backend bayern related to ehrenamtskarte bayern blocked Task or user story can not be continued at the moment Task web Task involves making changes to the administration module

Comments

@ztefanie
Copy link
Member

ztefanie commented Nov 7, 2024

For this feature #1751
To be able to push data to freinet (application/card data) we need an agencyId and accessKey
We have an api from freinet where we can fetch this information and map it via the regionIdentifiers (ars) to our regions

  • Fetch the freinet agencyId and accessKey in regular cycles and the maybe (or not) save them to our system. Evaluate if caching is enough or not. Updates in the freinet system are possible and need to lead to updates in our system, e.g. if a region is added to freinet.
  • show the agencyId and the accessKey in the region settings if they are available
@ztefanie ztefanie added the Task label Nov 7, 2024
@ztefanie ztefanie added this to the Feature Package Bavaria 2025 milestone Nov 7, 2024
@connium connium added the bayern related to ehrenamtskarte bayern label Jan 10, 2025
@f1sh1918 f1sh1918 moved this to Next Up in team-app Feb 3, 2025
@f1sh1918
Copy link
Contributor

f1sh1918 commented Feb 3, 2025

Since we need the agencyId for mapping accepting stores and for pushing data application data to freinet i think it makes sense to call the freinet api on backend start and store the agencyId in the regions table
This id will not change frequently, so i think on release to refetch it, it should be enough

@seluianova seluianova added web Task involves making changes to the administration module backend Task involves making changes to the backend labels Feb 3, 2025
@f1sh1918
Copy link
Contributor

f1sh1918 commented Feb 3, 2025

@ztefanie can you explain what bullet point 2 and 3 mean?
I think we just fetch this ids and i see no point in adding them manually?
Or do you mean if we cannot find any match?

@ztefanie
Copy link
Member Author

ztefanie commented Feb 4, 2025

yes, i think the idea was to map the freinet region ids with the eak region id's manually. But sure, if this can be done automatically, it is even better.

@f1sh1918 f1sh1918 self-assigned this Feb 5, 2025
@f1sh1918 f1sh1918 moved this from Next Up to In Progress in team-app Feb 5, 2025
@f1sh1918 f1sh1918 added the blocked Task or user story can not be continued at the moment label Feb 5, 2025
@f1sh1918
Copy link
Contributor

f1sh1918 commented Feb 5, 2025

Currently there are lots of wrong ars numbers so we can only map 40 regions, so far. I contacted freinet to check that.
In total we only get 50 regions out of 93 which is not sufficient :/

Since this xml won't change frequently i would rather hardcode the xml file from the api and read that instead of fetching it on every start.
agencyIds and ars shouldn't change.

@f1sh1918 f1sh1918 changed the title Add freinet client id to region settings Add freinet agency information Feb 10, 2025
@f1sh1918 f1sh1918 moved this from In Progress to In Review in team-app Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task involves making changes to the backend bayern related to ehrenamtskarte bayern blocked Task or user story can not be continued at the moment Task web Task involves making changes to the administration module
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

4 participants