Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor freinet CSV import #1700

Open
steffenkleinle opened this issue Oct 22, 2024 · 0 comments · May be fixed by #1765
Open

Refactor freinet CSV import #1700

steffenkleinle opened this issue Oct 22, 2024 · 0 comments · May be fixed by #1765
Assignees
Labels

Comments

@steffenkleinle
Copy link
Member

Is your feature request related to a problem? Please describe.
At the moment, the freinet CSV input is really hard to read and hacky, since the functions in it have a lot of side effects.
Arrays and objects are mutated and later it is just assumed that they are correctly modified before.

Describe the solution you'd like
Use functional programming and always explicitly return the updated value without implicitly assuming the necessary modifications happened.

Describe alternatives you've considered
None.

Additional context
None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant