-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update events listeners for page specific scripts #1667
base: master
Are you sure you want to change the base?
Conversation
lib/IHP/static/helpers.js
Outdated
@@ -1,10 +1,3 @@ | |||
var ihpLoadEvent = new Event('ihp:load'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a BC break, not sure whether that's worth it. ihpLoadEvent
is also used somewhere in the file, so we'd need to remove the usages as well in case we want to delete these variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a BC break, not sure whether that's worth it
In my tests I saw that ihp:load
was not working as expected. So on the one hand it's BC break, but on the other - people using it might think it's working. Should we ask on Slack who's using ihp:load
, see if we get people to answer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'm able to reproduce on my repo a case with |
Here's a reproducible example where the custom on ready handler isn't invoked transitioning into the page. |
ihp:load
on