Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jquery #2007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update jquery #2007

wants to merge 1 commit into from

Conversation

andreytroeglazov
Copy link
Contributor

mpscholten
mpscholten reviewed Nov 2, 2024
View reviewed changes
lib/IHP/static/vendor/jquery-3.5.0.min.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the old JS files will break existing IHP apps, so for now we sadly need to keep them :/

UPGRADE.md
@@ -942,9 +942,9 @@ Now you can start your project as usual with `./start`.

## Updating jQuery

The jQuery version used by IHP has changed. We're switching from `3.2.1` to `3.6.0`. jQuery `3.2.1` has some known security vulnerabilities, so it's recommended that you follow these update steps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to an older version of IHP. Ideally you could add a new entry for the next IHP release and add a note on the jquery upgrade

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry, this line confused me, will fix it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpscholten mpscholten mpscholten left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreytroeglazov @mpscholten