Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using along side with commitlint, throws error when jiraLocation is set to pre-type #70

Open
Byloor opened this issue Sep 15, 2022 · 3 comments

Comments

@Byloor
Copy link

Byloor commented Sep 15, 2022

Error for following message : Commit message: [CC-588] feat: haha

Screenshot 2022-09-15 at 13 57 34

@juliuscc
Copy link
Collaborator

That is a problem with how you have configured commitlint.

I used the following config in a previous project:

const types = require('conventional-commit-types').types;

module.exports = {
  extends: ['@commitlint/config-conventional'],
  plugins: ['subject'],
  rules: {
    'scope-empty': [2, 'always'],
    'type-enum': [2, 'always', Object.keys(types)],
    'subject-case': [0, 'always'],
    'subject-regexp': [2, 'always', /^DAZ-\d+\s.*/],
  },
};

It assumes that you don't want a scope, and that your JIRA-prefix is "DAZ".

@zhonig
Copy link

zhonig commented Mar 16, 2023

I am having the same issue when using type and/or scope. The issue is there is a space after the :
https://github.com/digitalroute/cz-conventional-changelog-for-jira/blob/master/engine.js#L41-L44

Can we add a new feature to make : configurable?

@juliuscc
Copy link
Collaborator

How would the commit message look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants