Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when changing environment in java project the code lens are not updated #373

Closed
shalom938 opened this issue Mar 12, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working java
Milestone

Comments

@shalom938
Copy link
Contributor

shalom938 commented Mar 12, 2023

when changing environment in java project the code lens are not updated.

What actually happened:
the code lens did not update
What effect it has on our system (System implications)
code lens are not updated

the intellij code vision daemon will only update code lens when the file is changed or closed/opened, or some time in the future when it will be triggered by something else.
so the files that are opened in the editor are not updated.
in C# for example we trigger an update when changing environment, probably its possible to do that for java too.

@shalom938 shalom938 added bug Something isn't working java labels Mar 12, 2023
@shaykeren shaykeren removed their assignment Mar 12, 2023
@shaykeren shaykeren pinned this issue Mar 12, 2023
@shalom938
Copy link
Contributor Author

@shaykeren @MykolaYaremchuk
I fixed it , but please do a test and if you think its ok you can close this issue.
same for python.

@MykolaYaremchuk
Copy link
Contributor

@shalom938 where can we see your fix? is it present in main branch?
image

maybe you've forgotten to push your changes?

@doppleware doppleware added this to the Sprint 1 milestone Mar 15, 2023
@shalom938
Copy link
Contributor Author

@MykolaYaremchuk I didn't forget.
It starts from org.digma.intellij.plugin.emvironment.EnvironmentChangeHandler#environmentChanged
and you can follow the code from there. eventually all code lens services will be notified that the environment changed and will refresh code lens.

@borisermakof borisermakof self-assigned this Mar 23, 2023
@borisermakof
Copy link
Contributor

Not reproducible. Checked in Rider and Intellij IDEA, everything is works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java
Projects
None yet
Development

No branches or pull requests

5 participants