Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload emote server's source code #6

Closed
RaptaG opened this issue Jun 5, 2023 · 8 comments
Closed

Upload emote server's source code #6

RaptaG opened this issue Jun 5, 2023 · 8 comments

Comments

@RaptaG
Copy link

RaptaG commented Jun 5, 2023

I opened this issue to track:


  • Where is the source code of the «emote server» to which the mod connects?

Not available anywhere yet (mostly because of the quality of the code), but will be available soon!


this, that is mentioned in the README. Not meant to add pressure, but for people who are interested in updates on this to subscribe in order to get notified.

@dima-dencep
Copy link
Owner

Am I correct in assuming that you only need the server code to keep track of its updates?

@RaptaG
Copy link
Author

RaptaG commented Jun 5, 2023

um, yes pretty much

@DearFox
Copy link

DearFox commented Jun 8, 2023

I think even if the server source code is bad at the moment, post it - then interested people can help you, point out problems. besides, it is interesting to observe the development and history of commits. And also anyone can deploy their own server if they need it.

@dima-dencep
Copy link
Owner

dima-dencep commented Jun 8, 2023

Own servers for this mod are one of the reasons why the server part with closed code

@DearFox
Copy link

DearFox commented Jun 8, 2023

Own servers for this mod are one of the reasons why the server part with closed code

That is, you do not plan to open source the server part?

@dima-dencep

This comment was marked as resolved.

@dima-dencep dima-dencep closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
@dima-dencep
Copy link
Owner

Right now there are no plans to open up the server code as online-emotes is part of RedlanceMinecraft's modular infrastructure and even if we publish it, it will take a lot of effort for you to run it on your computer, if you still want it I can share some parts of it with you privately.

@dima-dencep dima-dencep pinned this issue Jul 23, 2024
@dima-dencep dima-dencep changed the title [Not an issue] Upload emote server's source code Upload emote server's source code Jul 23, 2024
@dima-dencep
Copy link
Owner

I think even if the server source code is bad at the moment, post it - then interested people can help you, point out problems.

There are quite few people willing to maintain a custom server on netty these days, I've gained a lot of experience over the year and also now prefer java's built-in websocket api and will rewrite the mod for it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants