From 4bf6131212cbb10c142294ffc54234b4c8dc6f6a Mon Sep 17 00:00:00 2001 From: Niek <32094562+niekschoemaker@users.noreply.github.com> Date: Sun, 3 Nov 2024 05:19:24 +0100 Subject: [PATCH] fix: memory leak in event triggers (#1075) --- packages/discordx/CHANGELOG.md | 6 ++++++ packages/discordx/package.json | 2 +- packages/discordx/src/logic/metadata/MetadataStorage.ts | 3 +-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/discordx/CHANGELOG.md b/packages/discordx/CHANGELOG.md index d3d657994..081ceb107 100644 --- a/packages/discordx/CHANGELOG.md +++ b/packages/discordx/CHANGELOG.md @@ -1,5 +1,11 @@ # discordx +## 11.12.2 + +### Patch Changes + +- fix memory leak in event triggers + ## 11.12.1 ### Patch Changes diff --git a/packages/discordx/package.json b/packages/discordx/package.json index e6cfebc33..30feab0a3 100644 --- a/packages/discordx/package.json +++ b/packages/discordx/package.json @@ -1,6 +1,6 @@ { "name": "discordx", - "version": "11.12.1", + "version": "11.12.2", "private": false, "description": "Create a discord bot with TypeScript and Decorators!", "keywords": [ diff --git a/packages/discordx/src/logic/metadata/MetadataStorage.ts b/packages/discordx/src/logic/metadata/MetadataStorage.ts index 66dbecce2..42779392a 100644 --- a/packages/discordx/src/logic/metadata/MetadataStorage.ts +++ b/packages/discordx/src/logic/metadata/MetadataStorage.ts @@ -588,8 +588,6 @@ export class MetadataStorage { * @param options - Even data */ trigger(options: ITriggerEventData): (...params: any[]) => any { - const responses: any[] = []; - const eventsToExecute = this._events.filter((on) => { return ( on.event === options.event && @@ -599,6 +597,7 @@ export class MetadataStorage { }); return async (...params: any[]) => { + const responses: any[] = []; await Promise.all( eventsToExecute.map(async (ev) => { if (!ev.isBotAllowed(options.client.botId)) {