Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to exclude nested namespaces #1586

Open
ghostbuster91 opened this issue Sep 17, 2024 · 4 comments
Open

Allow to exclude nested namespaces #1586

ghostbuster91 opened this issue Sep 17, 2024 · 4 comments

Comments

@ghostbuster91
Copy link
Contributor

When generating scala classes from smithy model we often need to exclude certain namespaces due to various reasons.

For that we were using --exclude-ns option in smithy4s-cli. However, recently we did some small refactoring that moved some of the shapes from the top namespace that was excluded (e.g. a.b) into sub-namespaces (e.g. a.b.c and a.b.d).

This cause issues in the generated code as those nested namespaces were not excluded.

Would it be possible to allow excluding namespaces in a more convenient way? e.g. --exclude-ns a.b.* would exclude .a.b as well as any other namespace that starts with a.b

@kubukoz
Copy link
Member

kubukoz commented Sep 17, 2024

I'm all for it, if it's simple to implement then it shouldn't be a big deal to @Baccata either I assume

@Baccata
Copy link
Contributor

Baccata commented Sep 30, 2024

PR away :)

@kubukoz
Copy link
Member

kubukoz commented Oct 22, 2024

@Baccata how flexible do you think this should be? Accept arbitrary regex, or just wildcards (if so, only trailing/leading or everywhere?)

@Baccata
Copy link
Contributor

Baccata commented Oct 22, 2024

just wildcards (glob patterns) would be fine. Whatever you can find a concise implementation for.

@kubukoz kubukoz changed the title Allow to exclude namespaces nestead namespaces Allow to exclude nested namespaces Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants